Skip to content

Fix System certificates on Windows 11 #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DidierA wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix System certificates on Windows 11 #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions dploot/triage/certificates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,9 @@ def triage_system_certificates(self) -> List[Certificate]:
return certificates

def loot_system_certificates(self) -> Dict[str, x509.Certificate]:
my_certificates_key = (
"SOFTWARE\\Microsoft\\SystemCertificates\\MY\\Certificates"
my_certificates_keys = (
"SOFTWARE\\Microsoft\\SystemCertificates\\MY\\Certificates",
"SOFTWARE\\Microsoft\\SystemCertificates\\My\\Certificates",
)
certificate_keys = []
certificates = {}
Expand All @@ -138,11 +139,15 @@ def loot_system_certificates(self) -> Dict[str, x509.Certificate]:
reg = Registry(reg_file_path, isRemote=False)

# open key
key_path = my_certificates_key[8:]
parentKey = reg.findKey(key_path)
if parentKey is None:
for my_certificates_key in my_certificates_keys:
key_path = my_certificates_key[8:]
parentKey = reg.findKey(key_path)
if parentKey is not None:
break
else:
logging.error(f"Key {key_path} not found in {reg_file_path}")
return certificates

# for each certificate subkey (such as Microsoft\SystemCertificates\MY\Certificates\3FD2...)
for certificate_key in reg.enumKey(parentKey):
# get 'Blob' value
Expand All @@ -165,6 +170,7 @@ def loot_system_certificates(self) -> Dict[str, x509.Certificate]:
continue
reg.close()
else:
my_certificates_key=my_certificates_keys[0]
ans = rrp.hOpenLocalMachine(self.conn.remote_ops._RemoteOperations__rrp)
regHandle = ans["phKey"]

Expand Down