Skip to content

zfsbootmenu: support per-kernel command-line arguments#801

Merged
ahesford merged 2 commits intomasterfrom
who_jacked_da_fuckin_truck
Jan 29, 2026
Merged

zfsbootmenu: support per-kernel command-line arguments#801
ahesford merged 2 commits intomasterfrom
who_jacked_da_fuckin_truck

Conversation

@ahesford
Copy link
Member

@ahesford ahesford commented Jan 9, 2026

This is a rough sketch for now. It could use a bit of refining, and zfsbootmenu-preview is unaware of the selected kernel, which means that the kernel version never updates in the header and, now, neither does the KCL.

I think I've worked out the kinks, and everything respects the changing kernel.

@ahesford ahesford marked this pull request as draft January 9, 2026 03:59
@ahesford ahesford force-pushed the who_jacked_da_fuckin_truck branch 5 times, most recently from 5d0c302 to b316a82 Compare January 10, 2026 18:03
@ahesford ahesford marked this pull request as ready for review January 10, 2026 23:26
@ahesford ahesford force-pushed the who_jacked_da_fuckin_truck branch from b316a82 to d1576b1 Compare January 11, 2026 15:58
Copy link
Member

@zdykstra zdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the new /zfsbootmenu/$environment/kcl directory structure, should the value derived from OS initramfs defaults/ZFS property that's currently stored as /zfsbootmenu/$environment/cmdline be moved under the kcl/ directory to have them all in a single place? There's no way that filenames will conflict.

@ahesford
Copy link
Member Author

I now use the kernel_kcl_cache function with a default kernel path (which is never an acceptable path for a real kernel) to handle the property cache.

@ahesford ahesford force-pushed the who_jacked_da_fuckin_truck branch from cb45cc7 to 60bcc49 Compare January 29, 2026 14:32
@ahesford ahesford merged commit 82af0b6 into master Jan 29, 2026
3 checks passed
@ahesford ahesford deleted the who_jacked_da_fuckin_truck branch January 29, 2026 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants