add GetTaddressTransactions, label GetTaddressTxids deprecated #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two gRPC methods are functionally identical, just a name change (but leaving the old method deprecated during transition).
LarryRuane
force-pushed
the
2025-05-add-GetTaddressTransactions
branch
from
7b0c1b4 to
cf0b73a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #426.
Add
GetTaddressTransactionsas a new gRPC method, with the same functionality asGetTaddressTxids. The motivation is thatGetTaddressTransactionsis a more accurate name, since it returns transactions, not transaction IDs (txids). Label the old method as deprecated.