Use generalized Lookup version of Halo2 #429
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
reviewed
Jan 21, 2025
Cargo.toml
Outdated
| @@ -29,8 +29,8 @@ blake2b_simd = "1" | |||
| ff = "0.13" | |||
| fpe = "0.6" | |||
| group = { version = "0.13", features = ["wnaf-memuse"] } | |||
| halo2_gadgets = "0.3" | |||
| halo2_proofs = { version = "0.3", default-features = false, features = ["batch", "floor-planner-v1-legacy-pdqsort"] } | |||
| halo2_gadgets = { git = "https://github.com/QED-it/halo2", branch = "improve-backward-compatability-without-zsa" } | |||
There was a problem hiding this comment.
In general, we do not merge PRs that change dependencies in this way, for two reasons:
- It is a security issue to depend on a branch rather than a commit.
- We use
[patch.crates-io]instead for patching in-progress changes (and we then propagate those sections through the various downstream repos).
There was a problem hiding this comment.
I updated Cargo.toml to use patch.crates-io for halo2 repos.
This change updates the orchard crate to bring the PallasLookup trait into scope, ensuring compatibility with the recent changes in the halo2 crate. By importing the PallasLookup trait, we maintain backward compatibility and allow existing code to function without modification.
This reverts commit e5f8756.
ConstanceBeguier
force-pushed
the
zcash-0.8.0-new-halo2-compatible
branch
from
d8babc6 to
8c83f96
Compare
|
I just rebased on main branch and updated Cargo.toml to use patch.crates-io for halo2 repos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
orchardcrate to use the generalized version of thehalo2crate (link). It contains two key changes:LookupRangeChecktrait into scope (this maintains backward compatibility and allows existing code to function without additional modifications).Cargo.tomlto point to theimprove-backward-compatibility-without-zsabranch of thehalo2crate.