Pass the consumed proof bytes to the fingerprint fixture exporters - #544
Open
TalDerei wants to merge 7 commits into
Open
Pass the consumed proof bytes to the fingerprint fixture exporters#544TalDerei wants to merge 7 commits into
TalDerei wants to merge 7 commits into
Conversation
This was referenced Aug 26, 2026
TalDerei
commented
Aug 26, 2026
Comment on lines
+116
to
+118
| # Temporary until a halo2_proofs release includes zcash/halo2#933. | ||
| [patch.crates-io] | ||
| halo2_proofs = { git = "https://github.com/TalDerei/halo2.git", rev = "d9a8c7374192d299d11366ed159bc1b3d1a38902" } |
Collaborator
Author
There was a problem hiding this comment.
temporary patch, still needs to be tagged against zcash/halo2#933.
There was a problem hiding this comment.
Pull request overview
This PR updates Orchard’s verifier-fingerprint capture drivers to pass the exact proof byte string into halo2’s fixture exporters, so exported Lean fixtures can include the consumed proof bytes (as capturedProofHex) after the exporter’s re-serialization check.
Changes:
- Pass consumed proof bytes into the “honest” and “match-only” vesta Lean fixture exporters.
- Document the new exported
capturedProofHexbehavior in the changelog. - Temporarily patch
halo2_proofsto a git revision that contains the needed exporter APIs.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/circuit/fingerprint/mod.rs | Passes the honest proof bytes into the fixture exporter so fixtures carry capturedProofHex. |
| src/circuit/fingerprint/random.rs | Passes fabricated/replayed proof bytes into the match-only fixture exporter so fixtures carry capturedProofHex. |
| CHANGELOG.md | Documents that fixtures now include the consumed proof bytes (hex-encoded) after exporter re-serialization. |
| Cargo.toml | Adds a temporary [patch.crates-io] override for halo2_proofs to pick up the new exporter APIs. |
| Cargo.lock | Records the halo2_proofs source as the pinned git revision. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
TalDerei
marked this pull request as ready for review
August 27, 2026 04:41
The `verifier-fingerprint` capture drivers hand the proof byte string the verifier consumed to halo2's `dump_vesta_lean_fixture_with_proof_bytes` and its match-only sibling, so every exported fixture carries it hex-encoded as `capturedProofHex` after the exporter's re-serialization check. Requires a `halo2_proofs` release providing those exporters. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
TalDerei
force-pushed
the
fingerprint-proof-bytes
branch
from
August 27, 2026 07:56
eb5166b to
b812711
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to zcash/halo2#933 and consumed in zcash/ironwood#215.
This passes those proof bytes from Orchard’s capture drivers into the new halo2 exporters and negative test coverage so there's parity with the coverage Lean claims Orchard has. Still needs to be tagged against zcash/halo2#933.