Create Dockerfile #133
Open
Create Dockerfile #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
str4d
requested changes
May 12, 2025
| echo "zallet_version=$(echo ${{ github.ref_name }} | sed 's/v//g')" >> $GITHUB_OUTPUT | ||
|
|
||
| build_push: | ||
| uses: zcash/.github/.github/workflows/build-and-push-docker-hub.yaml@main |
There was a problem hiding this comment.
What is this doing? It looks recursive to me which makes no sense. Is this actually pulling from the zcash/zcash repo?
There was a problem hiding this comment.
Yes, this is the template we're using in Zcash and across several of our other repositories. - Just realized I missed updating a path — just fixed it now.
|
|
||
| - name: Run command inside Docker container | ||
| run: | | ||
| docker run --rm zallet -h |
There was a problem hiding this comment.
FYI the problem you last commit was fixing is that you tried to use -help as the flag, which is incorrect for Zallet. --help is what you should use (or -h), as the help text itself should show.
In general, zcashd's support for single-hypen word flags to CLI is not something we are going to support in Zallet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a multi-stage Docker build for the
zalletbinary, resulting in a minimal and secure container image.Build Stage (
builder)rust:1-slim(amd64).clang,libclang-dev,pkg-config,git).--releasemode.stripto reduce binary size.Runtime Stage (
distroless)gcr.io/distroless/ccfor a minimal and secure runtime environment.zalletbinary.Additional Changes
This setup ensures small image size, strong security practices, and a clear separation between build and runtime environments.