sync: Poll non-ephemeral transparent addresses for mined UTXOs #142
+108
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
str4d
commented
May 17, 2025
| // TODO: Once Zaino has an index over the mempool, monitor it for changes to the | ||
| // unmined UTXO set (which we can't get directly from the stream without building | ||
| // an index because existing mempool txs can be spent within the mempool). | ||
| while mempool_stream.next().await.is_some() {} |
There was a problem hiding this comment.
I spent a significant amount of time adding logic to turn mempool tx outputs into mempool UTXOs, only to remember at the end that later mempool transactions can spend outputs of earlier ones. Due to transactions not being guaranteed to leave the mempool across chain tip changes (e.g. during high load), that means we can't use the mempool stream to get UTXOs, and instead need to build and maintain an index (which is Zaino's job).
oxarbitrage
approved these changes
May 20, 2025
nuttycom
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.