Changes to create $ZSH_CACHE_DIR/completions directory #708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
war-turtle
requested review from
alichtman,
pschmitt and
vladdoster
as code owners
MangelMaxime
reviewed
Apr 3, 2025
Comment on lines
+168
to
+171
| # Create "$ZSH_CACHE_DIR/completions" directory | ||
| [[ ! -d "$ZSH_CACHE_DIR/completions" ]] && command mkdir -p "$ZSH_CACHE_DIR/completions" | ||
| # Add "$ZSH_CACHE_DIR/completions" diretory to fpath | ||
| [[ -z ${fpath[(re)$ZSH_CACHE_DIR/completions]} ]] && fpath=( "$ZSH_CACHE_DIR/completions" "${fpath[@]}" ) |
There was a problem hiding this comment.
Using this version of the code generated warning/error on my machine when going to zsh from a bash shell.
mkdir: cannot create directory ‘/completions’: Permission deniedI added these lines coming from oh-my-zsh repo:
# Make sure $ZSH_CACHE_DIR is writable, otherwise use a directory in $HOME
if [[ ! -w "$ZSH_CACHE_DIR" ]]; then
ZSH_CACHE_DIR="${XDG_CACHE_HOME:-$HOME/.cache}/oh-my-zsh"
fiThere was a problem hiding this comment.
@MangelMaxime thanks for this review. I have added the snippet you shared in the PR.
But, I changed the directory to .cache/zinit, I hope that's ok.
MangelMaxime
approved these changes
May 23, 2025
Comment on lines
+168
to
+171
| # Create "$ZSH_CACHE_DIR/completions" directory | ||
| [[ ! -d "$ZSH_CACHE_DIR/completions" ]] && command mkdir -p "$ZSH_CACHE_DIR/completions" | ||
| # Add "$ZSH_CACHE_DIR/completions" diretory to fpath | ||
| [[ -z ${fpath[(re)$ZSH_CACHE_DIR/completions]} ]] && fpath=( "$ZSH_CACHE_DIR/completions" "${fpath[@]}" ) |
pschmitt
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes to create $ZSH_CACHE_DIR/completions directory and add it to fpath.
Related Issue(s)
#707
Motivation and Context
Usage examples
How Has This Been Tested?
These line of changes were moved into a .zsh file
echo $fpath was added to the end of the file
then that file was executed to check if fpath was getting updated or not.
Also, the directory was created.
Types of changes
Checklist: