Open
Conversation
onItemToggle call is supposed to be invoked via watch 'model.opened' handler.
…efined for remote data retrieval
|
I started using this component (it's great btw :)) and I noticed the same thing. This PR definitely fixes it, but I don't know if it has any impacts on other functions. |
Author
|
fix dragstart to pass empty string for IE instead of null in e.dataTransfer.setData. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
onItemToggle call is supposed to be invoked via watch 'model.opened' handler. The onItemToggle call in handleItemToggle is duplicated. Please review.