Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the upload flow in the API service to migrate to a new upload API. Key changes include the implementation of a SHA256 content hash, replacing multipart form data with JSON requests, and a new multi-step upload process.
Comments suppressed due to low confidence (3)
pkg/api/service.go:412
- [nitpick] The variable 'createUploadResp' represents an HTTP request, so renaming it (e.g., to 'createUploadReq') would clarify its purpose.
createUploadResp, err := http.NewRequestWithContext(ctx, "POST", constant.ZeaburServerURL+"/v2/upload", bytes.NewReader(createUploadBody))
pkg/api/service.go:480
- [nitpick] The variable 'prepareResp' is used for an HTTP request. Renaming it to something like 'prepareReq' would help avoid confusion with actual responses.
prepareResp, err := http.NewRequestWithContext(ctx, "POST",
pkg/api/service.go:500
- The function returns (nil, nil) without returning a valid service object after a successful upload, which may be unintended behavior.
return nil, nil
yuaanlin
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description (required)
Migrate to new upload API.
Related issues & labels (optional)