-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add autohotkey-debugger extension #4269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autohotkey-debugger extension #4269
Conversation
Adds syntax highlighting and comment toggling for AutoHotkey v1 (.ahk files).
Debug adapter for AutoHotkey v1 scripts with breakpoints, stepping, and variable inspection. Complements the autohotkey tree-sitter extension.
|
Thanks for this! Is there any reason to not add this to the extension you want to add in #4266? |
Hi @MrSubidubi, just to keep as different repos, as they serve different purposes. Although they complement each other, it's easier to maintain/update |
The .gitmodules file was missing several submodule entries that exist in extensions.toml, causing CI validation to fail. Synced with upstream main to include all missing entries including autumnal-marscape.
The autumnal-marscape submodule directory exists but was missing from .gitmodules, causing CI validation to fail.
|
@MrSubidubi is there anything else pending to be able to merge? |
|
I think we would still prefer if you were to add this to the already published extension in an update - I do not really see what you mean by
but feel free to elaborate on that, and we genreally prefer for extensions to provide as much as possible, especially for language extensions. They do serve different purposes, that said, only together will the experience be quite good for users. Also, we generally tend to ship debuggers with the language wherever we can and I'd honestly prefer if were were to not make this an exception here, especially given that you own the two repositories. Feel free to provide arguments as well if you disagree, but how I currently see it, the cost of adding it to the other repository is minimal, as there is no Rust code involved so far, and everything could just go in a |
|
@MrSubidubi I had the "separation of concerns" mindset as my reason to keep it separated, and because the debugger repository is a fork of another repository. But I completely understand and agree with your point, for a language extension, it makes much more sense to have everything into one for a better user experience. I'm closing this PR as I open a new one to update the main extension with the debugger merged into it, thank you for your attention, wish you a great day Here's the PR to update the existing extension: #4383 |
Summary
Adds the AutoHotkey Debugger extension for Zed.
Features:
This complements the existing
autohotkeytree-sitter extension (#4266) to provide a complete AutoHotkey development experience in Zed.Repository: https://github.com/alfredomtx/zed-autohotkey-debugger
License: MIT