-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Add Laravel extension #4392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add Laravel extension #4392
Conversation
Adds comprehensive Laravel support for Zed including: - Blade template syntax highlighting (tree-sitter-blade) - Go to Definition for @include/@extends directives - PHP syntax support (tree-sitter-php) - Laravel Language Server integration - Intelephense integration - 120+ code snippets (Blade, PHP Laravel, Livewire 3) - Laravel Pint formatting support Repository: https://github.com/croustibat/zed-laravel
|
We require contributors to sign our Contributor License Agreement, and we don't have @croustibat on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @croustibat on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
MrSubidubi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
Aside fromt the CLA issue, a few questions:
- Could you elaborate how this differs for the highlighting part from https://github.com/bajrangCoder/zed-laravel-blade? It seems that this already adds support for both highlighting as well as some LSPs.
- I see that this adds the laravel language server. Would that perhaps be something that we could add to the other extension too instead?
Thanks!
|
@cla-bot check |
|
We require contributors to sign our Contributor License Agreement, and we don't have @croustibat on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Thanks for the review! You're right that
I'm happy to contribute the Laravel LS integration to the existing That would avoid duplication of the grammar/highlighting parts. Should I:
Let me know what makes more sense for the Zed extension ecosystem! |
|
Thanks for the reply! I'd love if you could open a PR against As for the snippets, they could in theory also go in that extension, however, we can also publish these as a separete extension, whatever you and/or the upstream maintainer prefer. At the end, though, happy to go with whatever you'd like (aside from preventing the duplication of language definitions to happen). |
Summary
Adds comprehensive Laravel support for Zed Editor.
Features
Blade Template Support
@include/@extendsdirectivesPHP Development
Code Snippets (120+)
@if,@foreach,@extends, etc.Laravel Pint formatting support
Repository
https://github.com/croustibat/zed-laravel
Testing
Checklist