tally: v0.44.0#6311
Conversation
Have feedback on this plugin? Let's hear it! |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9ac60fb6da
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| [tally] | ||
| submodule = "extensions/tally" | ||
| path = "_integrations/zed-tally" |
There was a problem hiding this comment.
Because this registry entry packages the _integrations/zed-tally subdirectory, pnpm package-extensions validates the LICENSE found there; at the referenced submodule SHA that file is AGPL-3.0-only, while validateLicense only accepts Apache-2.0, BSD, CC-BY-4.0, GPLv3, LGPLv3, MIT, Unlicense, or zlib. The new extension will therefore fail the package job before it can be published unless this path contains an allowed license or the registry validator is updated to accept AGPL.
Useful? React with 👍 / 👎.
| submodule = "extensions/zwirn" | ||
| version = "0.2.0" | ||
|
|
||
| [tally] |
There was a problem hiding this comment.
Adding tally after zwirn leaves the registry files out of lexical order; the package job runs sortExtensionsToml/sortGitmodules and the CI workflow then fails if those commands changed extensions.toml or .gitmodules. After the blocking packaging issue is fixed, this will still fail CI until the new [tally] entry and matching submodule block are placed with the other t* entries.
Useful? React with 👍 / 👎.
2 participants
Publishing version v0.44.0 of the tally extension.
Tally is a Dockerfile linter and formatter written in Go, promoting modern container syntax and helping avoid common pitfalls.
Changelog