Subagents PR 2: Thread spawning + execution #46187
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
rtfeldman
force-pushed
the
subagents-pr1
branch
from
833ea0c to
6fcfeef
Compare
rtfeldman
force-pushed
the
subagents-pr2
branch
from
4b3efc7 to
4ddad52
Compare
rtfeldman
force-pushed
the
subagents-pr1
branch
from
6fcfeef to
1eeaa97
Compare
rtfeldman
force-pushed
the
subagents-pr2
branch
from
4ddad52 to
0840c8d
Compare
rtfeldman
force-pushed
the
subagents-pr1
branch
from
1eeaa97 to
0dc1777
Compare
- Add SubagentsFeatureFlag with staff-disabled default - Create SubagentTool with input schema for task/summary/context-low prompts - Register SubagentTool conditionally when feature flag is enabled - Tool returns stub message 'not yet implemented' for now Amp-Thread-ID: https://ampcode.com/threads/T-019b94c4-0a15-7799-aba2-83a644590a2e Co-authored-by: Amp <[email protected]>
Core subagent execution: - Add Thread::new_subagent() constructor for creating subagent threads - Implement SubagentTool::run() to spawn and manage subagent lifecycle - Add SubagentContext for parent-child thread relationship - Implement submit_user_message(), interrupt_for_summary(), request_final_summary() - Add timeout support and context-low detection - Propagate cancellation from parent to child threads Thread management: - Add MAX_SUBAGENT_DEPTH (4) and MAX_PARALLEL_SUBAGENTS (8) limits - Add register/unregister_running_subagent() for tracking - Add restrict_tools() for allowed_tools filtering - Add is_subagent(), depth(), is_turn_complete() accessors ACP thread changes: - Add ToolCallContent::SubagentThread variant - Add ToolCallUpdateSubagentThread for UI updates - Add tool_name field for subagent detection - Add is_subagent() method on ToolCall - Add image support in ContentBlock Comprehensive test coverage for all subagent scenarios
rtfeldman
force-pushed
the
subagents-pr2
branch
from
0840c8d to
8e2e197
Compare
SomeoneToIgnore
added
the
area:ai
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements the core subagent execution logic:
Core subagent execution
Thread::new_subagent()constructor for creating subagent threadsSubagentTool::run()to spawn and manage subagent lifecycleSubagentContextfor parent-child thread relationshipsubmit_user_message(),interrupt_for_summary(),request_final_summary()Thread management
MAX_SUBAGENT_DEPTH(4) andMAX_PARALLEL_SUBAGENTS(8) limitsregister/unregister_running_subagent()for trackingrestrict_tools()for allowed_tools filteringis_subagent(),depth(),is_turn_complete()accessorsACP thread changes
ToolCallContent::SubagentThreadvariantToolCallUpdateSubagentThreadfor UI updatestool_namefield for subagent detectionis_subagent()method onToolCallContentBlockTests
Comprehensive test coverage for all subagent scenarios.
Part of stacked PRs
This is PR 2 of 4 for the subagents feature: