editor: Fix DeleteToPreviousSubwordStart and DeleteToNextSubwordEnd interaction with newlines #46235
+179
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We require contributors to sign our Contributor License Agreement, and we don't have @RubenFricke on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
cla-bot
bot
added
the
cla-signed
|
The cla-bot has been summoned, and re-checked this pull request! |
RubenFricke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #40110
Changes:
DeleteToPreviousSubwordStartnow deletes\nseparately from preceding subwords and whitespace.DeleteToNextSubwordEndnow deletes\nand any following whitespace separately from subsequent subwords.ignore_newlinesflag to both actions to optionally retain the old behavior.These modifications align the subword commands with their word counterparts and with other popular editors like VSCode and Sublime.
Related to: #16848
Release Notes:
DeleteToPreviousSubwordStartandDeleteToNextSubwordEndinteractions around newlines. You can opt-in into the previous behavior by adding{"ignore_newlines": true}to either action's binds in your keymap.This is my first contribution to Zed! If anything should be done differently, please let me know. Happy to learn :)