Fix multiline regex #46298
Merged
Fix multiline regex #46298
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
This comment was marked as resolved.
This comment was marked as resolved.
SomeoneToIgnore
requested changes
Jan 8, 2026
Contributor
SomeoneToIgnore
left a comment
SomeoneToIgnore
left a comment
There was a problem hiding this comment.
There is a way to add a test for this, is there not?
| @@ -180,6 +180,10 @@ impl SearchQuery { | |||
| } | |||
|
|
|||
| let multiline = query.contains('\n') || query.contains("\\n"); | |||
| if multiline { | |||
| query.insert_str(0, "(?m)"); | |||
Contributor
There was a problem hiding this comment.
Can there be a situation when a query already contains this?
Then, we'll spoil it by doing so?
Collaborator
Author
There was a problem hiding this comment.
That's a really good observation thanks! I just tested it and it works just the same as if you hadn't included it.
Collaborator
Author
|
@SomeoneToIgnore Good catch. Just added a test. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #45776
It didn't enable multiline mode before
¯\_(ツ)_/¯. If there is a reason this fix won't work please let me know but it seems like this one was just an easy fix.Release Notes: