recent_projects: Connect on Enter from a remote host header#60171
Open
aanyberg wants to merge 1 commit into
Open
recent_projects: Connect on Enter from a remote host header#60171aanyberg wants to merge 1 commit into
aanyberg wants to merge 1 commit into
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @aanyberg on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
Author
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
The host header row was inert, so searching for a host and pressing Enter did nothing - users had to arrow down to the "Open Folder" row. Make the header a selectable confirm target that connects and opens the remote folder chooser, mirroring "Open Folder". Both paths now share a single open_folder_for_server helper, and the footer shows an "Open Folder" button when a header is selected.
aanyberg
force-pushed
the
feat/remote-host-enter-connect
branch
from
July 17, 2026 21:17
40688d1 to
d0dd79b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The host header row was inert, so searching for a host and pressing Enter did nothing - users had to arrow down to the "Open Folder" row. Make the header a selectable confirm target that connects and opens the remote folder chooser, mirroring "Open Folder". Both paths now share a single open_folder_for_server helper, and the footer shows an "Open Folder" button when a header is selected.
Objective
In the remote server picker, searching for a host and pressing Enter did nothing — the host header row was inert, so users had to arrow down to the "Open Folder" row to connect. This makes the header row behave like a real confirm target.
Solution
RemoteMatch::ServerHeaderis now selectable (is_selectableonly excludesSeparator), so search + Enter lands on it andconfirmconnects.RemoteServerPickerDelegate::open_folder_for_serverhelper (via a smallFolderConnectTargetenum) so both the header row and the existing "Open Folder" row drive the exact same connect-and-open-folder flow - persisted SSH connections reuse theirServerIndex, and ssh-config-only hosts are first persisted viacreate_host_from_ssh_config.Testing
RemoteMatch::is_selectableandfolder_connect_target's routing for persisted vs. ssh-config-only entries.gpui::tests verifying that searching a host selects its header (not a stale project row beneath it) and that an ssh-config-only host's header is selectable and followed by its "Open Folder" row.cargo test -p recent_projects --lib remote_servers- all 19 tests pass.Self-Review Checklist:
Showcase
Click to view showcase
Release Notes: