fix: add error handling on HTTP client errors #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the HTTP client returns an error, it is not safe to access the response object `resp` (e.g. when the server presents a certificate that the client does not trust) and the provider process will likely crash with a segfault exception.
Collaborator
eriknordmark
left a comment
eriknordmark
left a comment
There was a problem hiding this comment.
Any idea why we don't see crashes die to this issue? Can we somehow force the http get to fail so we can exercise this error path before and after your fix?
Author
|
Probably we didn't see this error earlier as any ZEDEDA control server that is exposed to the Internet presents a certificate that is signed by a public CA, hence typically trusted by clients. But there could also be other failure modes (e.g. if a user configures a ZedCloud URL with an invalid URL scheme) that lead to a crash of the provider. Examples to reproduce the error: |
ikurakin-zededa
approved these changes
Oct 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the HTTP client returns an error, it is not safe to access the response object
resp(e.g. when the server presents a certificate that the client does not trust) and the provider process will likely crash with a segfault exception.