Enable using of configured http proxy for media #1298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, configured http proxy (
Config.proxy,Config.proxy_auth) is only used for API calls. Media (twimg.com) is always downloaded directly. This PR adds usage of proxy for media too.This PR adds some code duplication: both
http_poolandroutes/mediamodules now havesetHttpProxymethod andproxyvar. Maybe I should refactor this a bit and make single global var and setter somewhere, but I'm not sure where to put it.Also, maybe there should be separate proxy settings for API and media in config?
This is my first code edits in nim language.