Dag generators #28
Open
Dag generators #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remvee
requested changes
Dec 15, 2020
|
|
||
| When ~graph~ is ~"tree"~, the generated graph is a directed | ||
| acyclic graph with a single root note that has a nil reference - | ||
| in this case: ~{"person/father: ["person/name" nil]}~ |
Collaborator
There was a problem hiding this comment.
This is a bit confusing. This section is called "graphs and trees" but this paragraph indicates we're generating treelike graphs. Either change the title or describe what happens when the options "graph: tree" is omitted.
| When a ~nilabe~ option is provided, this indicates the chance | ||
| (between 0 and 1) that any generated ref is a nil reference - a | ||
| new root. Combined with the ~graph: "tree"~ option above this | ||
| implies a forest of independent trees. |
Collaborator
There was a problem hiding this comment.
So what happens when "nilable" is omitted? Does it generate an infinite forest? Please describe.
|
|
||
| Options is a map of keywords to values | ||
|
|
||
| * `:graph :tree` |
Collaborator
There was a problem hiding this comment.
Use - instead of *, this isn't orgmode. ;-)
| for the tree's root, and there is only a single path between any two | ||
| nodes in the graph. | ||
|
|
||
| * `:nilable CHANCE` |
| (is (= 4 (count (keep (comp second :cat/parent) (:cat world)))) | ||
| "One root for a tree") | ||
| (is (false? (detect-cycle world :cat/parent))))) | ||
|
|
Collaborator
There was a problem hiding this comment.
Missing test case for nilable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.