style: clean up redundant virtual

[TingleDinkle]

Changes:

• worldShootingStarMgr.h: removed virtual from init_() and calc_() which already have override
• dmgStruct20.h: removed virtual from Struct20::combineMaybe() which already has override

---

This change is 

[Pistonight]

@TingleDinkle just curious, are you following some kind of list for these clean ups? The places you are changing and the type of clean ups seem a bit random. If possible you can do all of the clean up of the same category (like removing virtual) for the entire code base in the same PR. I think the commit history will be a bit cleaner that way

[TingleDinkle]

@TingleDinkle just curious, are you following some kind of list for these clean ups? The places you are changing and the type of clean ups seem a bit random. If possible you can do all of the clean up of the same category (like removing virtual) for the entire code base in the same PR. I think the commit history will be a bit cleaner that way

So I just sorta dive into the codebase and click around and read then make changes where I see, no list. You're right that it is random because it absolutely is haha :)

Noted though, makes sense to do cleanups of the same nature in one commit. This is my first open-source project contribution so I'm getting used to these semantics.

[TingleDinkle]

I've seen no other instances of issues in this category (virtual redundancy) but in these 2 files. Should be good right?

[Pistonight]

Thanks @TingleDinkle, if you want to continue these clean-ups, a good place to start is by running clang-tidy. There are thounsands of warnings right now. Some are legitimated and others we want to disable the rule in .clang-tidy (usually because every instance of the warning is because it's needed for matching)

[TingleDinkle]

Thanks @TingleDinkle, if you want to continue these clean-ups, a good place to start is by running clang-tidy. There are thounsands of warnings right now. Some are legitimated and others we want to disable the rule in .clang-tidy (usually because every instance of the warning is because it's needed for matching)

Haha yeah, you caught me :) I'll definitely look into .clang-tidy rules and zip its complaining mouth where I can once I set it up