Skip to content

Implement CheckE3Mode::doQuery#160

Merged
Pistonight merged 1 commit intozeldaret:masterfrom
hgh32:master
Mar 5, 2026
Merged

Implement CheckE3Mode::doQuery#160
Pistonight merged 1 commit intozeldaret:masterfrom
hgh32:master

Conversation

@hgh32
Copy link
Contributor

@hgh32 hgh32 commented Feb 24, 2026

This change is Reviewable

@Pistonight
Copy link
Collaborator

@hgh32 LGTM but can you clang-format the changes? (and then squash the commit to one).

@hgh32
Copy link
Contributor Author

hgh32 commented Feb 28, 2026

done

@Pistonight
Copy link
Collaborator

@hgh32 One last thing, can you squash your branch to one commit by doing the following

Add this repo as upstream remote

git add remote upstream https://github.com/zeldaret/botw
git fetch upstream master

Start rebasing your branch to upstream/master

git rebase -i upstream/master

In the rebase todo file, change pick to fixup in every commit except for the first one.
Then force push your branch to origin

git push -f

@hgh32
Copy link
Contributor Author

hgh32 commented Mar 5, 2026

Okay, should be finished now.

@Pistonight
Copy link
Collaborator

LGTM, thanks for the PR

@Pistonight Pistonight merged commit f4da5c8 into zeldaret:master Mar 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants