Implement CheckE3Mode::doQuery#160
Merged
Pistonight merged 1 commit intozeldaret:masterfrom Mar 5, 2026
Merged
Conversation
Collaborator
|
@hgh32 LGTM but can you clang-format the changes? (and then squash the commit to one). |
Contributor
Author
|
done |
Collaborator
|
@hgh32 One last thing, can you squash your branch to one commit by doing the following Add this repo as Start rebasing your branch to In the rebase todo file, change |
Contributor
Author
|
Okay, should be finished now. |
Pistonight
approved these changes
Mar 5, 2026
Collaborator
|
LGTM, thanks for the PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is