Match physStaticCompoundUtil shape and collidable helpers - #186
Open
RobbyV2 wants to merge 2 commits into
Open
Conversation
Pistonight
reviewed
Aug 3, 2026
Pistonight
left a comment
Collaborator
There was a problem hiding this comment.
@Pistonight made 2 comments.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on RobbyV2).
src/KingSystem/Physics/StaticCompound/physStaticCompoundUtil.h line 22 at r1 (raw file):
const sead::Vector3f& position); // 0x0000007100fd086c
We can remove these address comments
src/KingSystem/Physics/StaticCompound/physStaticCompoundUtil.cpp line 20 at r1 (raw file):
}; if (shape.getType() == hkcdShapeType::BV_COMPRESSED_MESH) {
does a switch statement work?
Contributor
Author
Done.
Yes, changed it to that now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getMaterialMaskFromCollidable was declared bool. A bool return makes clang append
and w0, w0, #0x1at the shared exit, four bytes over the target, so it's a u32 now.0x710164f960 is hkpBvCompressedMeshShape::getPrimitiveUserData, a Havok symbol the new code calls, so I moved it to L.
This change is