Skip to content

Match physStaticCompoundUtil shape and collidable helpers - #186

Open
RobbyV2 wants to merge 2 commits into
zeldaret:masterfrom
RobbyV2:phys-static-compound-util
Open

Match physStaticCompoundUtil shape and collidable helpers#186
RobbyV2 wants to merge 2 commits into
zeldaret:masterfrom
RobbyV2:phys-static-compound-util

Conversation

@RobbyV2

@RobbyV2 RobbyV2 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

getMaterialMaskFromCollidable was declared bool. A bool return makes clang append and w0, w0, #0x1 at the shared exit, four bytes over the target, so it's a u32 now.

0x710164f960 is hkpBvCompressedMeshShape::getPrimitiveUserData, a Havok symbol the new code calls, so I moved it to L.


This change is Reviewable

@Pistonight Pistonight left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pistonight made 2 comments.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on RobbyV2).


src/KingSystem/Physics/StaticCompound/physStaticCompoundUtil.h line 22 at r1 (raw file):

                             const sead::Vector3f& position);

// 0x0000007100fd086c

We can remove these address comments


src/KingSystem/Physics/StaticCompound/physStaticCompoundUtil.cpp line 20 at r1 (raw file):

    };

    if (shape.getType() == hkcdShapeType::BV_COMPRESSED_MESH) {

does a switch statement work?

@RobbyV2

RobbyV2 commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

We can remove these address comments

Done.

does a switch statement work?

Yes, changed it to that now.

@RobbyV2
RobbyV2 requested a review from Pistonight August 3, 2026 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants