Game/Damage: Implement DamageMgrShield - #187
Conversation
53d2949 to
17e96c2
Compare
|
It's possible the name in the code and in IDA/csv are different. Unless the game has strings to indicate one over the other it's up to us to pick one (hopefully this issue will become less of a deal when the new tool is made) that said since the code already has |
Pistonight
left a comment
There was a problem hiding this comment.
@Pistonight made 4 comments.
Reviewable status: 0 of 7 files reviewed, 4 unresolved discussions (waiting on german77).
src/Game/Damage/dmgDamageManagerBase.h line 128 at r1 (raw file):
inline void tryApplyDamageRecovery(s32& damage); void setDamageType(s32 type) { mDamageType = type; }
Is this an enum?
src/Game/Damage/dmgDamageMgrShield.h line 7 at r1 (raw file):
namespace ksys::act { // TODO: Move Chemical to correct file
is it possible ksys::act::Chemical and ksys::world::Chemical are the same? (there's ChemicalMgr looks like hasn't been RE'ed much)
src/Game/Damage/dmgDamageMgrShield.h line 10 at r1 (raw file):
class Chemical { public: char filler[0xc0];
convention is u8 _0[0xc0];
src/Game/Damage/dmgDamageMgrShield.h line 24 at r1 (raw file):
~DamageMgrShield() override; void setDamage2(f32 damage) override;
Do we have better names for these?
This is the first PR with an actual implementation. I have more questions than anything specially with names and file locations. We have
DamageMgrBasebut alsoDamageManagerBaseand they appear to be the same thing?ksys::res::Chemicalbut this impl requiresksys::act::Chemical?hieldSurfDamageLogicandshieldDamageLogiccast from Actor to something else. I couldn't figure out which actor this is meant to be so for now I left those out.Another thing to note is that the vtable is wrong, the order is not correct for rtti elements but this is probably an issue in
DamageManagerBaseand not in this classThis change is