Skip to content

Match phys::System static group handlers - #189

Open
RobbyV2 wants to merge 1 commit into
zeldaret:masterfrom
RobbyV2:phys-system-static-group-handlers
Open

Match phys::System static group handlers#189
RobbyV2 wants to merge 1 commit into
zeldaret:masterfrom
RobbyV2:phys-system-static-group-handlers

Conversation

@RobbyV2

@RobbyV2 RobbyV2 commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

I made the StaticGroupHandlerId parameter of both getters a SEAD_ENUM rather than an int, because the target spills that index to the stack and reloads it while indexing the outer dimension from w1 directly. The round trip comes from SEAD_ENUM's operator int() const volatile, and with an int both getters come out 40 bytes against the target's 52. The enumerator names are unknown, so they're written in the repo's _N placeholder style.


This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant