Fixed Dockerfile. - #1882
Merged
Merged
Conversation
Dockerfile updated per the file on https://practicerom.com/public/packages/debian/howto.txt and Debian/Ubuntu's apt-key command being deprecated.
hensldm
added
Tooling
Needs-second-approval
hensldm
reviewed
Aug 1, 2026
hensldm
reviewed
Aug 2, 2026
hensldm
reviewed
Aug 26, 2026
AngheloAlf
reviewed
Aug 28, 2026
AngheloAlf
left a comment
AngheloAlf
left a comment
Collaborator
There was a problem hiding this comment.
We are trying to get everybody who has contributed / wants to contribute to MM decomp to agree to licensing the repo before merging PRs from people who have not yet agreed to it. It is better explained here: louist103/mm-licensing#1.
Could you please read about it and post in that issue if you agree or not. Thanks!
Contributor
Author
|
Removed sudo from the Dockerfile (as it is indeed not required) and agreed to the aforementioned license. |
hensldm
approved these changes
Aug 29, 2026
AngheloAlf
approved these changes
Aug 30, 2026
AngheloAlf
added
Merge-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dockerfile updated per the file on https://practicerom.com/public/packages/debian/howto.txt and Debian/Ubuntu's apt-key command being deprecated.