New assets system - #1886
Draft
Dragorn421 wants to merge 18 commits into
Draft
Conversation
AngheloAlf
reviewed
Aug 11, 2026
AngheloAlf
reviewed
Aug 11, 2026
| // Reference data: used to store the original vertices | ||
| static Vtx sBigslimeStaticVtx[BIGSLIME_NUM_VTX] = { | ||
| #include "assets/overlays/ovl_En_Bigslime/sBigslimeStaticVtx.vtx.inc" | ||
| #include "assets/overlays/ovl_En_Bigslime/sBigslimeStaticVtx.inc.c" |
Collaborator
There was a problem hiding this comment.
I kinda prefer the .inc extension over the .c extension for these generated assets.
They aren't C files, they can't be compiled on their own, they have to be included this way to have meaning, so an extension reflecting this sounds better to me
Contributor
Author
There was a problem hiding this comment.
Hmm but the .c extension has the advantage that IDEs will at least syntax-highlight the contents like it's C which is mostly correct
Collaborator
There was a problem hiding this comment.
IDEs usually let you configure this, so people can decide to opt in instead of forcing everyone into this.
For example, you can add this to your .vscode/settings.json
{
"files.associations": {
"*.inc": "c"
}
}but whatever, i guess it is fine
hensldm
added
Tooling
Asset
Needs-second-approval
New assets build warning fixups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently WIP but OK!
Help welcome on implementing the MM-specific data structures:
AnimatedMaterial[](partially started for matching reasons intools/assets/extract/extase_oot64/animated_materials.py)KeyFrameAnimationKeyFrameSkelAlso need a csdis.py for MM like OoT has for disassembling cutscene data.