Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup colliders 3 #2467

Merged
merged 7 commits into from
Feb 15, 2025
Merged

Cleanup colliders 3 #2467

merged 7 commits into from
Feb 15, 2025

Conversation

Dragorn421
Copy link
Collaborator

@Dragorn421 Dragorn421 commented Feb 12, 2025

#2465 continued

  • standardize ColliderJntSphElementInit data names on s[Name][Collider]JntSphElementsInit[Name] (for now, in the future s[Name][Collider]JntSphElementsInit)
  • standardize ColliderCylinder struct members names on [name]collider[Cylinder][s] ([s] if it's an array of colliders)

Copy link
Collaborator

@fig02 fig02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think in the future most cases of colliderCylinder can just be bodyCollider

@fig02
Copy link
Collaborator

fig02 commented Feb 13, 2025

theres still an issue in bongo it seems (boss_sst)

@Dragorn421
Copy link
Collaborator Author

Thanks
I was confused because it built OK from clean for me locally, but it turned out the faulty code was in a version-ifdefed region 🙃

src/overlays/actors/ovl_Demo_Gj/z_demo_gj.h Outdated Show resolved Hide resolved
@fig02 fig02 merged commit 6f8b4d8 into zeldaret:main Feb 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants