Partial linking of spec segments #2661
+1,571
−1,749
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Contributor
There was a problem hiding this comment. It isn't possible to just have all those symbols in the same file?
Collaborator
Author
There was a problem hiding this comment. The BSS order is now enforced at partial link rather than final link. The plugin errors if it can't find a mentioned symbol in any of the input files, since this can often point to a user error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| // Specification for linker plugin COMMON symbol order for the ique-cn version boot segment | ||
|
|
||
| build/ique-cn/boot_bss_1.o { | ||
| bk; | ||
| __osBaseCounter; | ||
| __osBbRCountWraps; | ||
| __osBbLastRCount; | ||
| __osViIntrCount; | ||
| insize; | ||
| outcnt; | ||
| bb; | ||
| __osCurrentTime; | ||
| hufts; | ||
| __osBbLastVCount; | ||
| __osTimerCounter; | ||
| __osBbVCountWraps; | ||
| __osFinalrom; | ||
| inptr; | ||
| ifd; | ||
| } | ||
|
|
||
| build/ique-cn/boot_bss_boot_main.o { | ||
| sBootThreadInfo; | ||
| sIdleThread; | ||
| sIdleThreadStack; | ||
| sIdleThreadInfo; | ||
| sBootThreadStack; | ||
| } | ||
|
|
||
| build/ique-cn/boot_bss_idle.o { | ||
| sMainThread; | ||
| sMainStack; | ||
| sMainStackInfo; | ||
| sPiMgrCmdBuff; | ||
| } | ||
|
|
||
| build/ique-cn/boot_bss_viconfig.o { | ||
| gViConfigMode; | ||
| gViConfigModeType; | ||
| } | ||
|
|
||
| build/ique-cn/boot_bss_z_std_dma.o { | ||
| sDmaMgrStackInfo; | ||
| sDmaMgrMsgQueue; | ||
| sDmaMgrMsgBuf; | ||
| sDmaMgrThread; | ||
| sDmaMgrStack; | ||
| } | ||
|
|
||
| build/ique-cn/boot_bss_2.o { | ||
| __osThreadSave; | ||
| __Dom2SpeedParam; | ||
| __CartRomHandle; | ||
| __osPiAccessQueue; | ||
| __Dom1SpeedParam; | ||
| gPiMgrCmdQueue; | ||
| __osBaseTimer; | ||
| __osEventStateTab; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit dense.
So we are now autogenerating a Makefile for those plfs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, the way it works is:
filter-out)$(SEGMENTS_DIR)/Makefileexists.$(SEGMENTS_DIR)/Makefile, if it doesn't exist it will execute that rule and any rules it relies on to make$(SEGMENTS_DIR)/Makefileavailable.Generating a makefile from the spec for each plf is the most convenient way to handle dependencies that I can think of that doesn't involve separating by directory (since we can't do that for multiversion anyway when files move between boot and code)