Comment more original names for audio functions from animal crossing#2721
Comment more original names for audio functions from animal crossing#2721Thar0 wants to merge 2 commits intozeldaret:mainfrom
Conversation
| } | ||
|
|
||
| /** | ||
| * original name: Nas_StartVoice |
There was a problem hiding this comment.
A bit off topic, but I haven't been following the audio portion of decomp nearly as close as other parts of decomp because I haven't particularly studied how digital sound works. Like I've studied a little bit of music but just nowhere near comfortable to understand all that I'm looking at.
But seeing this made me question what all is within the Note struct, and having looked through and hardly understood even half of it, to me it seems like there's way more detail than the typical definition of a musical note (pitch and duration).
| } | ||
|
|
||
| /** | ||
| * original name possibly Na_StartOcarinaBgm |
There was a problem hiding this comment.
Where does this name come from? I can't find it in the repo, nor in ACreTeam/ac-decomp, nor in zeldaret/af, nor in the AC map files
There was a problem hiding this comment.
JP versions of Majora's Mask have strings no other versions seem to have
$ strings baseroms/n64-jp-1.1/baserom-decompressed.z64 | grep Na_StartOc
Na_StartOcarinaSinglePlayCheck2( message->ocarina_no );
Na_StartOcarinaBgm Na_StartOcarinaBgm Na_StartOcarinaBgm
| } | ||
|
|
||
| /** | ||
| * original name possibly "Nap_SilenceCheck" |
There was a problem hiding this comment.
Where does this name come from?
There was a problem hiding this comment.
Guess, inferred from the function it calls being called Nap_SilenceCheck_Inner, it's the only sensible-looking candidate for a "non-inner" variant
include/audio.h
Outdated
| /* 0x10 */ SoundEffect* soundEffects; | ||
| } SoundFont; // size = 0x14 | ||
|
|
||
| // JAudio: "delayparam" |
There was a problem hiding this comment.
Do you know where do the struct names and struct member names come from in the AC decomp?
There was a problem hiding this comment.
I don't. Matching the structs was informative for me, but I was reluctant to label them as "original"
There was a problem hiding this comment.
| // JAudio: "delayparam" |
It turns out this name is made up
|
About the JAudio struct names, they mostly come from the map file (C++ mangled names) but some are made up. |
Dragorn421
added
the
One approval
3 participants
A follow-on to #2513
Comments original names for more files that largely remained intact into animal crossing