z_player.c: enum for trade item identification#2769
Open
GhostlyDark wants to merge 1 commit into
Open
Conversation
c194e8b to
3b1a027
Compare
Contributor
Author
|
Format check appears to be hung up on other files: |
Collaborator
|
We use clang-format-14 specifically, probably you have a more recent version installed which would explain the differences and why the format check fails |
Use the enum value from item.h instead of the hardcoded 0x18, which equals the first bottle item, seemingly for identifying trade items.
3b1a027 to
3e7d34b
Compare
|
This is correct, it looks a bit awkward but this allows using PLAYER_IA enum to convert to EXCH_ITEM despite the fact that PLAYER_IA has the relevant bottle items before the other exchange items (and some non-trade bottle items inbetween) and EXCH_ITEM has bottle items after other exchange items. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the enum value from
item.hinstead of the hardcoded0x18, which equals the first bottle item, seemingly for identifying trade items.