Skip to content

d_t_barrel and d_t_barrel_pos#274

Merged
elijah-thomas774 merged 6 commits intozeldaret:mainfrom
elijah-thomas774:d_t_barrel
Nov 23, 2025
Merged

d_t_barrel and d_t_barrel_pos#274
elijah-thomas774 merged 6 commits intozeldaret:mainfrom
elijah-thomas774:d_t_barrel

Conversation

@elijah-thomas774
Copy link
Copy Markdown
Collaborator

d_t_barrel has weak function ordering issue
image

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Nov 23, 2025

Report for SOUE01 (fc4700e - c0b8b12)

📈 Matched code: 22.16% (+0.03%, +3676 bytes)
📈 Linked code: 13.81% (+0.00%, +572 bytes)

✅ 23 new matches
Unit Function Bytes Before After
d_t_barrelNP/REL/d/t/d_t_barrel dTgBarrel_c::executeState_Wait() +733 0.54% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dTgBarrel_c::checkPlayerPos(const mVec3_c&) +540 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dTgBarrel_c::~dTgBarrel_c() +264 0.00% 100.00%
d_t_barrel_posNP/REL/d/t/d_t_barrel_pos dTgBarrelPos_c::actorExecute() +224 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dTgBarrel_c::actorCreate() +192 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dTgBarrel_c::actorPostCreate() +156 0.00% 100.00%
d_t_barrel_posNP/REL/d/t/d_t_barrel_pos dTgBarrelPos_c::create() +124 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dTgBarrel_c::executeState_Stop() +113 3.45% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dTgBarrel_c_classInit() +91 64.80% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dTg_c::~dTg_c() +88 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dAcRef_c<dAcOBarrel_c>::~dAcRef_c() +88 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dAcRef_c<dTgBarrelPos_c>::~dAcRef_c() +88 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dTgBarrel_c::actorExecute() +48 0.00% 100.00%
d_t_barrel_posNP/REL/d/t/d_t_barrel_pos dTgBarrelPos_c::~dTgBarrelPos_c() +29 75.86% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel unsigned char sLib::calcTimer<unsigned char>(unsigned char*) +28 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dAcRef_c<dAcOBarrel_c>::dAcRef_c() +20 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dAcRef_c<dTgBarrelPos_c>::dAcRef_c() +20 0.00% 100.00%
d_t_barrel_posNP/REL/d/t/d_t_barrel_pos dTgBarrelPos_c_classInit() +19 79.70% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dTgBarrel_c::doDelete() +8 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel dTgBarrel_c::draw() +8 0.00% 100.00%
d_t_barrel_posNP/REL/d/t/d_t_barrel_pos dTgBarrelPos_c::doDelete() +8 0.00% 100.00%
d_t_barrel_posNP/REL/d/t/d_t_barrel_pos dTgBarrelPos_c::draw() +8 0.00% 100.00%
d_t_barrelNP/REL/d/t/d_t_barrel __sinit_\d_t_barrel_cpp +1 99.88% 100.00%

Comment thread src/REL/d/t/d_t_barrel.cpp Outdated
Comment thread include/d/t/d_t_barrel.h Outdated
Comment thread include/d/t/d_t_barrel.h Outdated
Comment on lines 56 to 60
lbl_442_data_88 = .data:0x00000088; // type:object size:0x30
lbl_442_data_B8 = .data:0x000000B8; // type:object size:0x30
lbl_442_data_E8 = .data:0x000000E8; // type:object size:0x18
lbl_442_data_100 = .data:0x00000100; // type:object size:0x10C
lbl_442_data_20C = .data:0x0000020C; // type:object size:0x34
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to mark these as scope:local to prevent linker warnings. We forgot that for dAcOBarrel_c again already...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure Ill fix that

@elijah-thomas774 elijah-thomas774 merged commit 08623f9 into zeldaret:main Nov 23, 2025
1 check passed
@elijah-thomas774 elijah-thomas774 deleted the d_t_barrel branch November 23, 2025 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants