Merged
Conversation
Report for SOUE01 (a67ebab - cb5e001)📈 Matched code: 22.36% (+0.06%, +7560 bytes) ✅ 46 new matches
...and 16 more new matches |
elijah-thomas774
approved these changes
Nov 27, 2025
Collaborator
elijah-thomas774
left a comment
elijah-thomas774
left a comment
There was a problem hiding this comment.
Provided some comments on what I can easily read through logically.
| #define DRAW_MARK_NUM_PANES 13 | ||
|
|
||
| bool dLytDrawMark_c::build(UNKWORD) { | ||
| mVariant = dScGame_c::currentSpawnInfo.layer == 3 ? 1 : dScGame_c::currentSpawnInfo.layer == 4 ? 2 : 0; |
Collaborator
There was a problem hiding this comment.
Layer 2 -> Imp1 (Variant 0)
Layer 3 -> Imp2 (Variant 1)
Layer 4 -> Imp3 (Variant 2)
Collaborator
There was a problem hiding this comment.
Easy to notice when reading the file, and the context of the class.
I think they omitted the Stage check since there is no need due to this only existing post imprisoned fight.
| fn_800ADC10(mVec2_c(0.0f, 0.0f)); | ||
| field_0x884.x = field_0x884.y = 0.0f; | ||
| field_0x87C.set(0.0f, 0.0f); | ||
| dLytDobutton_c::setActionTextStuff(dLytDobutton_c::ICON_2, dLytDobutton_c::ACT_DO_70, true); |
Collaborator
There was a problem hiding this comment.
ACT_DO_70 -> this corresponds to the swing prompts correct?
Collaborator
Author
There was a problem hiding this comment.
ACT_DO_70 is empty. ICON_2 corresponds to N_swing_00 though. We'll clean this up in dLytDoButton_c at some point...
| if (mAnm[mLineLoopIndex + DRAW_MARK_ANIM_DRAW_LINE_LOOP_OFFSET].getFrame() == 1.0f) { | ||
| dSndSmallEffectMgr_c::GetInstance()->playSound(SE_S_SEAL_LINE_BLINK); | ||
| } | ||
| if (field_0x941) { |
Collaborator
There was a problem hiding this comment.
Anything externally change this variable? This would seem to act as a force complete flag
| field_0x874 = mStartPositions[mLineLoopIndex]; | ||
| // unused | ||
| mVec2_c _ = mEndPositions[mLineLoopIndex] - mStartPositions[mLineLoopIndex]; | ||
| if (field_0x8F4 == -1) { |
Collaborator
There was a problem hiding this comment.
This variable seems to indicate the current line index. -1 indicating failure or a reset for the next line to draw?
Comment on lines
+337
to
+340
| if (field_0x904 > 0) { | ||
| field_0x87C = field_0x884; | ||
| field_0x904--; | ||
| } |
Collaborator
There was a problem hiding this comment.
First Frame position save? (0x904 is set to 1 usually?)
Comment on lines
+342
to
+345
| if (field_0x908 > 0) { | ||
| field_0x908--; | ||
| field_0x87C = field_0x884; | ||
| } else { |
Collaborator
There was a problem hiding this comment.
This seems to act as a cooldown time?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.