Skip to content

d_a_b_lastboss 99%#292

Merged
robojumper merged 13 commits intozeldaret:mainfrom
robojumper:lastboss
Jan 28, 2026
Merged

d_a_b_lastboss 99%#292
robojumper merged 13 commits intozeldaret:mainfrom
robojumper:lastboss

Conversation

@robojumper
Copy link
Copy Markdown
Collaborator

@robojumper robojumper commented Dec 28, 2025

No description provided.

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Dec 28, 2025 •
edited
Loading

Report for SOUE01 (cffba79 - e9033d7)

📈 Matched code: 23.74% (+0.30%, +37096 bytes)
📈 Linked code: 14.81% (+0.02%, +2980 bytes)
📈 Matched data: 14.03% (+0.03%, +824 bytes)
📈 Linked data: 25.20% (+0.00%, +120 bytes)

✅ 109 new matches
Unit Item Bytes Before After
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::actorExecute() +6056 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::callback_c::timingB(unsigned long, nw4r::g3d::WorldMtxManip*, nw4r::g3d::ResMdl) +2140 0.00% 100.00%
main/toBeSorted/d_sword_swing_effect_mgr dSwordSwingEffectProcMgr_c::createSwingEntries(const mVec3_c&, const mVec3_c&) +2140 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_Fight() +1813 0.22% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_Down() +1737 0.23% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::updateMainNodeTransforms() +1144 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_Guard() +1045 0.38% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::create() +1016 0.00% 100.00%
main/toBeSorted/d_sword_swing_effect dSwordSwingEffectProc_c::drawXlu() +996 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::checkForCounter() +824 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::createHeap() +804 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_DashAttack() +796 0.50% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c_classInit() +788 14.72% 100.00%
main/toBeSorted/d_sword_swing_effect dSwordSwingEffectProcBase_c::drawXlu() +780 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_CounterAttack() +756 0.53% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::~dAcBlastboss_c() +744 19.23% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_SmallAttack() +724 0.55% 100.00%
main/toBeSorted/d_enemy_sword_mdl dEnemySwordMdl_c::calc(const mMtx_c&, const mVec3_c&, bool) +680 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_Attack() +672 0.59% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::checkForRangeAttack() +536 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_ThunderAttack() +516 0.77% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_SitDamage() +512 0.78% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_ThunderWait() +512 0.78% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_Stun() +396 1.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::checkForCloseRangeAttack() +380 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::checkForLinkSwordBySwordHit() +328 0.00% 100.00%
main/toBeSorted/d_enemy_sword_mdl dEnemySwordMdl_c::create(mAllocator_c*, void*, const char*, unsigned long, const mVec3_c&, const mVec3_c&, cCcD_Stts&, EGG::ResTIMG*, int, unsigned long*) +320 0.00% 100.00%
main/toBeSorted/d_enemy_sword_mdl dEnemySwordMdl_c::create(mAllocator_c*, nw4r::g3d::ResFile, const char*, unsigned long, const mVec3_c&, const mVec3_c&, cCcD_Stts&, EGG::ResTIMG*, int, unsigned long*) +316 0.00% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeState_PunchAttack() +288 1.37% 100.00%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::initializeState_CounterAttack() +244 1.61% 100.00%

...and 79 more new matches

📈 11 improvements in unmatched functions
Unit Item Bytes Before After
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::checkDamage() +2994 0.00% 99.95%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::executeLightningStrike() +2802 0.00% 99.95%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::updateSkirtTransform(long) +2129 0.00% 99.30%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::updateSkirtHairTransforms() +1650 0.00% 99.88%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss dAcBlastboss_c::updateHairTransform(long) +1451 0.00% 99.42%
d_a_b_lastbossNP/REL/d/a/b/d_a_b_lastboss .bss +672 0.00% 70.00%
main/toBeSorted/d_sword_swing_effect_mgr fn_8006A8D0(const mVec2_c&, const mVec2_c&, const mVec2_c&, const mVec2_c&, mVec2_c&) +451 0.00% 94.83%
main/d/d_stage_mgr dStageMgr_c::~dStageMgr_c() +74 52.37% 61.88%
main/toBeSorted/d_enemy_sword_mdl .data +45 0.00% 95.65%
main/d/d_stage_mgr dStageMgr_c::dStageMgr_c() +35 51.16% 54.88%
main/toBeSorted/d_enemy_sword_mdl .sdata2 +5 0.00% 66.67%

@robojumper robojumper changed the title d_a_b_lastboss WIP d_a_b_lastboss Jan 2, 2026
@robojumper robojumper marked this pull request as ready for review January 2, 2026 10:45
@robojumper robojumper changed the title d_a_b_lastboss d_a_b_lastboss 99% Jan 2, 2026
elijah-thomas774
elijah-thomas774 approved these changes Jan 25, 2026
View reviewed changes
Comment thread src/toBeSorted/d_enemy_sword_mdl.cpp Outdated
Comment thread include/toBeSorted/d_enemy_sword_mdl.h
/* 0x098 */ mVec3_c field_0x098;
/* 0x0A4 */ f32 field_0x0A4;
/* 0x0A8 */ f32 field_0x0A8;
/* 0x0AC */ dCcD_Linked_Cps mCcs[3];
Copy link
Copy Markdown
Collaborator

@elijah-thomas774 elijah-thomas774 Jan 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we know what the 3 colliders are here? I noticed in the one function it was start/end and what I am throwing a baseless guess for active sword

Copy link
Copy Markdown
Collaborator Author

@robojumper robojumper Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't entirely sure so I left it for later. We'll have more enemies with even more swords :)

Comment thread src/toBeSorted/d_sword_swing_effect.cpp Outdated
Comment thread include/d/a/obj/d_a_obj_base.h
Comment thread src/REL/d/a/b/d_a_b_lastboss.cpp Outdated
@robojumper robojumper merged commit 734ec3a into zeldaret:main Jan 28, 2026
1 check passed
@robojumper robojumper deleted the lastboss branch January 28, 2026 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@elijah-thomas774 elijah-thomas774 elijah-thomas774 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@robojumper @elijah-thomas774