Merged
Conversation
Report for eur (47785bb - 18e7561)📈 Matched code: 1.28% (+0.02%, +864 bytes) ✅ 21 new matches
📈 3 improvements in unmatched functions
Report for jp (47785bb - 18e7561)📈 Matched code: 1.26% (+0.02%, +864 bytes) ✅ 21 new matches
📈 3 improvements in unmatched functions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't get far because I lost my motivation on
UnkSystem1_ov000_Base::vfunc_04and the other two functions (vfunc_10andvfunc_14) are very big so it didn't motivate me much lolAs far as I can tell it's more related to BMG actually, I feel like it's some kind of system that is used to connect certain text events (like pressing OK) to actions,
UnkSystem1_ov000_Base.mUnk_08is a bitfield composed of the message index (lower bits) and I think the BMG file (the upper bits), and I tried to follow pointers in memory but it's very not consistent with the actual code so I'm extremely confusedWhen I follow the thing in the memory viewer I end up on the
INF1section of a BMG file (in this case it wasselect.bmgin my tests) but the structure is more consistent with theFLW1section (aka offset 1 being a u8 and offset 2 being a u16) so I'm just lost, I guess it will be clearer once BMG stuff is decompiled more (but idk if I want to go inside that rabbit hole again lol)Anyway, here's my little work, I didn't expect to give up so soon but I don't want to keep working on this for now