Skip to content

Misc things#30

Merged
Yanis002 merged 13 commits intozeldaret:mainfrom
Yanis002:random_stuff
Feb 3, 2026
Merged

Misc things#30
Yanis002 merged 13 commits intozeldaret:mainfrom
Yanis002:random_stuff

Conversation

@Yanis002
Copy link
Collaborator

@Yanis002 Yanis002 commented Feb 2, 2026 •
edited
Loading

Changes:

  • matched Random::Init
  • named various things about the clickable buttons (see UnkSystem2_UnkSubSystem1_Base and derived ones)
  • documented lots of button IDs
  • I think Random might be finally figured out now
  • random Actor Rupee improvements

@decomp-dev
Copy link

decomp-dev bot commented Feb 2, 2026 •
edited
Loading

Report for jp (7803163 - aef37ac)

📈 Matched code: 1.33% (+0.07%, +3284 bytes)
📈 Matched data: 22.17% (+0.01%, +160 bytes)

✅ 13 new matches
Unit Item Bytes Before After
src/019_MainSelect/FileSelectSubScreen FileSelect_UnkClass7::FileSelect_UnkClass7() +396 0.00% 100.00%
src/019_MainSelect/FileSelectOptions FileSelectOptions::FileSelectOptions(int) +165 75.17% 100.00%
src/031_Land/Actor/ActorRupee ActorRupee::func_ov031_020e9108() +157 2.30% 100.00%
src/019_MainSelect/FileSelectSubScreen FileSelect_UnkClass7::vfunc_00() +131 38.49% 100.00%
src/Main/System/Random Random::Init() +128 0.00% 100.00%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c72a0() +33 95.50% 100.00%
src/031_Land/Actor/ActorRupee .data +29 81.05% 100.00%
src/000_Second/Actor/Actor Actor::vfunc_18(int) +8 0.00% 100.00%
src/019_MainSelect/019_UnkSubStruct9 UnkSubStruct9::func_ov019_020cc5ac(Vec2us*) +8 60.00% 100.00%
src/019_MainSelect/FileSelectSubScreen .rodata +8 0.00% 100.00%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c6d48() +1 99.96% 100.00%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c82c4() +1 99.90% 100.00%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020ca6a4() +1 99.89% 100.00%
📈 17 improvements in unmatched items
Unit Item Bytes Before After
src/031_Land/Actor/ActorRupee ActorRupee::vfunc_18(int) +422 0.00% 90.97%
src/019_MainSelect/019_UnkSubStruct9 UnkSubStruct9::UnkSubStruct9(stack_struct1) +217 72.00% 96.13%
src/019_MainSelect/FileSelectMain FileSelectMain::FileSelectMain() +181 38.86% 46.21%
src/031_Land/Actor/ActorRupee ActorRupee::vfunc_2c(int) +175 0.00% 59.34%
src/019_MainSelect/FileSelectSubScreen FileSelectSubScreen::FileSelectSubScreen() +106 79.88% 92.20%
src/031_Land/Actor/ActorRupee ActorRupee::func_ov031_020e8d2c(Vec3p*, unsigned char, int, int) +91 0.00% 73.61%
src/031_Land/Actor/ActorRupee Actor_c4::vfunc_00(Actor_c4_stack, int) +61 0.00% 90.59%
src/019_MainSelect/FileSelectMain FileSelectMain::vfunc_08(Input*, TouchControl*) +26 91.14% 97.50%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c854c() +18 97.51% 98.83%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c8c4c() +17 97.84% 98.86%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c7a44() +15 61.40% 64.46%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c7dc8() +4 82.66% 83.16%
src/000_Second/Actor/Actor .data +2 84.69% 86.87%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c92dc() +1 93.21% 93.26%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c9e08() +1 90.45% 90.48%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020ca940() +1 91.68% 91.72%
src/019_MainSelect/FileSelectOptions FileSelectOptions::func_ov019_020cd8d4() +1 99.69% 99.78%
📉 3 regressions in unmatched items
Unit Item Bytes Before After
src/031_Land/Actor/ActorRupee Actor_c4::vfunc_00(int, int) -46 68.24% 0.00%
src/019_MainSelect/FileSelectSubScreen UnkStructSub2::UnkStructSub2() -13 3.42% 0.00%
src/031_Land/Actor/ActorRupee ActorRupee::vfunc_18() -1 0.34% 0.00%

Report for eur (7803163 - aef37ac)

📈 Matched code: 1.35% (+0.07%, +3284 bytes)
📈 Matched data: 22.19% (+0.01%, +160 bytes)

✅ 13 new matches
Unit Item Bytes Before After
src/019_MainSelect/FileSelectSubScreen FileSelect_UnkClass7::FileSelect_UnkClass7() +396 0.00% 100.00%
src/019_MainSelect/FileSelectOptions FileSelectOptions::FileSelectOptions(int) +165 75.17% 100.00%
src/031_Land/Actor/ActorRupee ActorRupee::func_ov031_020e9108() +157 2.30% 100.00%
src/019_MainSelect/FileSelectSubScreen FileSelect_UnkClass7::vfunc_00() +131 38.49% 100.00%
src/Main/System/Random Random::Init() +128 0.00% 100.00%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c72a0() +33 95.50% 100.00%
src/031_Land/Actor/ActorRupee .data +29 81.05% 100.00%
src/000_Second/Actor/Actor Actor::vfunc_18(int) +8 0.00% 100.00%
src/019_MainSelect/019_UnkSubStruct9 UnkSubStruct9::func_ov019_020cc5ac(Vec2us*) +8 60.00% 100.00%
src/019_MainSelect/FileSelectSubScreen .rodata +8 0.00% 100.00%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c6d48() +1 99.96% 100.00%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c82c4() +1 99.90% 100.00%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020ca6a4() +1 99.89% 100.00%
📈 17 improvements in unmatched items
Unit Item Bytes Before After
src/031_Land/Actor/ActorRupee ActorRupee::vfunc_18(int) +422 0.00% 90.97%
src/019_MainSelect/019_UnkSubStruct9 UnkSubStruct9::UnkSubStruct9(stack_struct1) +217 72.00% 96.13%
src/019_MainSelect/FileSelectMain FileSelectMain::FileSelectMain() +181 38.86% 46.21%
src/031_Land/Actor/ActorRupee ActorRupee::vfunc_2c(int) +175 0.00% 59.34%
src/019_MainSelect/FileSelectSubScreen FileSelectSubScreen::FileSelectSubScreen() +106 79.88% 92.20%
src/031_Land/Actor/ActorRupee ActorRupee::func_ov031_020e8d2c(Vec3p*, unsigned char, int, int) +91 0.00% 73.61%
src/031_Land/Actor/ActorRupee Actor_c4::vfunc_00(Actor_c4_stack, int) +61 0.00% 90.59%
src/019_MainSelect/FileSelectMain FileSelectMain::vfunc_08(Input*, TouchControl*) +26 91.14% 97.50%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c854c() +18 97.51% 98.83%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c8c4c() +17 97.84% 98.86%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c7a44() +15 61.40% 64.46%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c7dc8() +4 82.66% 83.16%
src/000_Second/Actor/Actor .data +2 84.69% 86.87%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c92dc() +1 93.21% 93.26%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020c9e08() +1 90.45% 90.48%
src/019_MainSelect/FileSelectMain FileSelectMain::func_ov019_020ca940() +1 91.68% 91.72%
src/019_MainSelect/FileSelectOptions FileSelectOptions::func_ov019_020cd8d4() +1 99.69% 99.78%
📉 3 regressions in unmatched items
Unit Item Bytes Before After
src/031_Land/Actor/ActorRupee Actor_c4::vfunc_00(int, int) -46 68.24% 0.00%
src/019_MainSelect/FileSelectSubScreen UnkStructSub2::UnkStructSub2() -13 3.42% 0.00%
src/031_Land/Actor/ActorRupee ActorRupee::vfunc_18() -1 0.34% 0.00%

@Yanis002 Yanis002 marked this pull request as ready for review February 3, 2026 18:53
@Yanis002 Yanis002 merged commit 3ab5bf6 into zeldaret:main Feb 3, 2026
4 of 5 checks passed
@Yanis002 Yanis002 deleted the random_stuff branch February 3, 2026 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@Yanis002