Conversation
Report for GZ2E01 (efcf241 - 8cea19c)📈 Matched code: 59.56% (+0.02%, +2140 bytes) 📈 |
src/d/actor/d_a_npc_cd.cpp
Outdated
|
|
||
| J3DModelData* a_mdlData_p = getNpcMdlDataP(param_1); | ||
| #ifdef DEBUG | ||
| if (a_mdlData_p == NULL) { |
There was a problem hiding this comment.
JUT_ASSERT instead of this ifdef block
src/d/actor/d_a_npc_cd.cpp
Outdated
|
|
||
| mCreature.init(¤t.pos, &eyePos, 3, 1); | ||
| mCreature.setMdlType(param_1, true, mIsDarkWorld); | ||
| // mpMorf->offTranslate(); |
There was a problem hiding this comment.
You can add #if VERSION == VERSION_SHIELD_DEBUG
Instead of the comment
src/d/actor/d_a_npc_cd.cpp
Outdated
| JUT_ASSERT(574, m_type < MdlNUM_e); | ||
|
|
||
| u32 rv = field_0x9c4 ^ 16; | ||
| return (((int)rv >> 1) - (rv & 16)) >> 31; |
There was a problem hiding this comment.
field_0x9c4 should be int, the return type is BOOL and then this function just returns field_0x9c4 < 16
See https://decomp.me/scratch/YGTin
src/d/actor/d_a_npc_cd.cpp
Outdated
| 3, 0, 0, | ||
| }; | ||
|
|
||
| if ((mIsDarkWorld && daPy_py_c::checkNowWolfEyeUp() == 0)) { |
There was a problem hiding this comment.
!daPy_py_c::checkNowWolfEyeUp()
src/d/actor/d_a_npc_cd.cpp
Outdated
| // NONMATCHING | ||
| } | ||
| int daNpcCd_c::drawNpc() { | ||
| if (mIsDarkWorld && daPy_py_c::checkNowWolfEyeUp() == 0) { |
There was a problem hiding this comment.
!daPy_py_c::checkNowWolfEyeUp()
* Work on create function * General work * Pull request cleanup * Remove unnecessary semicolon --------- Co-authored-by: hatal175 <hatal175@users.noreply.github.com>
2 participants
No description provided.