Merged
Conversation
Report for GZ2E01 (773c0ad - d780f47)📈 Matched code: 59.60% (+0.04%, +4328 bytes) ✅ |
TakaRikka
reviewed
May 11, 2025
TakaRikka
approved these changes
May 11, 2025
meintte
pushed a commit
to meintte/tp
that referenced
this pull request
May 28, 2025
* d_a_npc_cd fmt * d_a_npc_cd equivalent? * d_a_npc_cd cleaner * d_a_npc_cd pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another janitor job from #2429 🧹 (Some random changes are to try and match debug)
Sad that this does not match, the only two issues I can see are that
daNpcCd_HIO_c::~daNpcCd_HIO_c()gets placed too early and that thedaNpcCd_c::setAttention(int)::a_eyeOfsTbl guardis placed in.sbss, instead of being "extern"? Not sure if that is an easy fix or not a problem?