Merged
Conversation
Report for GZ2E01 (0a899a4 - 2dd89d0)📈 Matched code: 66.09% (+0.01%, +1196 bytes) ✅ 2 new matches:
📈 1 improvements in unmatched functions:
|
TakaRikka
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yesterday cadmic and I discovered that the
(void)0;from J3D_ASSERTs ifdefed out for retail inside of inlines affects a number of things, including regalloc throughout the whole function that calls any of these inlines (e.g. dMenu_Collect3D_c::setJ3D), and instruction ordering around the places these inlines get called (e.g. J3DMaterialTable::entryTexMtxAnimator).There's probably more of these asserts I missed, worth keeping in mind to check for missing debug asserts in the future when working on functions that call J3D inlines.