Fix incorrect PCH being used in some framework objects#2604
Merged
TakaRikka merged 1 commit intozeldaret:mainfrom Aug 25, 2025
Merged
Fix incorrect PCH being used in some framework objects#2604TakaRikka merged 1 commit intozeldaret:mainfrom
TakaRikka merged 1 commit intozeldaret:mainfrom
Conversation
caseif
force-pushed
the
dolzel-debug-fix
branch
from
1fc5d0a to
a756170
Compare
caseif
force-pushed
the
dolzel-debug-fix
branch
from
a756170 to
af84d48
Compare
TakaRikka
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where objects under
d/actorwhich are not RELs were incorrectly including the REL version of the PCH, which broke the debug build. This also removes the PCH include fromd_a_npc2.cpp,d_a_npc3.cpp, andd_a_npc4.cppwhich are not objects and are instead included fromd_a_npc.cpp.