Merged
Conversation
hatal175
requested changes
Feb 3, 2025
src/d/actor/d_a_obj_ktOnFire.cpp
Outdated
| */ | ||
| static void daKtOnFire_Draw(daKtOnFire_c* param_0) { | ||
| // NONMATCHING | ||
| param_0->Draw(); |
Contributor
There was a problem hiding this comment.
The draw, delete and execute static functions usually have an int return value that propagates the inner function return value.
TakaRikka
reviewed
Feb 3, 2025
include/d/actor/d_a_obj_ktOnFire.h
Outdated
Comment on lines
+21
to
+23
| /* 8058CA1C */ void Execute(); | ||
| /* 8058CDF8 */ bool Draw(); | ||
| /* 8058CE00 */ void Delete(); | ||
| /* 8058CE00 */ bool Delete(); |
Contributor
There was a problem hiding this comment.
just adding on to what hatal said, all actors generally have a create, delete, draw and execute function, and sometimes a createHeap and isDelete function, which should all return int values to stay consistent
hatal175
approved these changes
Feb 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decompile of ktOnFire setLight() function.
First PR for reverse engineering and this repo, wanted to do something very simple to start.