d_a_e_zs (a.k.a. Stallord's zombie soldiers) equivalent#2313
d_a_e_zs (a.k.a. Stallord's zombie soldiers) equivalent#2313TakaRikka merged 4 commits intozeldaret:mainfrom
Conversation
src/d/actor/d_a_e_zs.cpp
Outdated
| /* 8083329C-8083364C 0002DC 03B0+00 1/1 0/0 0/0 .text damage_check__8daE_ZS_cFv */ | ||
| void daE_ZS_c::damage_check() { | ||
| // NONMATCHING | ||
| /* 808353C8-808353D0 00007C 0006+02 1/1 0/0 0/0 .data eff_Damage_id$3979 */ |
There was a problem hiding this comment.
you can remove the symbol info comment when its an in-function static imo, the info isnt particularly useful for these
src/d/actor/d_a_e_zs.cpp
Outdated
| if (field_0x670) { | ||
| --field_0x670; | ||
| } | ||
|
|
||
| if (field_0x671) { | ||
| --field_0x671; | ||
| } |
There was a problem hiding this comment.
since these appear to be timers or counters of some sort, it's better to do an explicit comparison with 0 imo
src/d/actor/d_a_e_zs.cpp
Outdated
|
|
||
| /* 808346DC-808346E4 00171C 0008+00 1/0 0/0 0/0 .text daE_ZS_IsDelete__FP8daE_ZS_c */ | ||
| static bool daE_ZS_IsDelete(daE_ZS_c* param_0) { | ||
| static bool daE_ZS_IsDelete(daE_ZS_c* i_this) { |
There was a problem hiding this comment.
remember that all actor base methods (create, delete, isDelete, execute, draw) should return int values
src/d/actor/d_a_e_zs.cpp
Outdated
| int phase = dComIfG_resLoad(&mPhase, "E_ZS"); | ||
| if (phase == cPhs_COMPLEATE_e) { | ||
| OS_REPORT("E_ZS PARAM %x\n", fopAcM_GetParam(this)); | ||
| if (!fopAcM_entrySolidHeap(this, (heapCallbackFunc)useHeapInit, 0xfc0)) { |
There was a problem hiding this comment.
minor style thing again, but i like to use uppercase for hex literal values
There was a problem hiding this comment.
I cleaned up a few cases, though I will try to do this moving forward.
src/d/actor/d_a_e_zs.cpp
Outdated
| fopAc_CULLBOX_CUSTOM_e, // cullType | ||
| }; | ||
|
|
||
| /* 80835344-80835344 000074 0000+00 0/0 0/0 0/0 .rodata @stringBase0 */ |
There was a problem hiding this comment.
very minor cleanup thing, but these stringbase lines that end up at the end of TUs sometimes can just be removed. they're unimportant
2 participants
Feel free to give whatever style feedback, and I'll incorporate it.