decompile d_a_obj_bmshutter.cpp#2338
Merged
TakaRikka merged 11 commits intozeldaret:mainfrom Mar 22, 2025
Merged
Conversation
Closed
TakaRikka
reviewed
Mar 22, 2025
…CommandDemoAccrpt
This reverts commit dc7e945.
Contributor
Author
|
I have adjusted the code. Thank you for the detailed comments! |
TakaRikka
approved these changes
Mar 22, 2025
Stbn-antier
pushed a commit
to Stbn-antier/tp
that referenced
this pull request
Mar 24, 2025
* Implement `onCondition` inline function of `dEvt_info_c` * decompile d_a_obj_bmshutter.cpp * remove uncesary inline and this-> * use dEvt_info_c::checkCommandDemoAccrpt instead of daObjBmSh_c::checkCommandDemoAccrpt * change style of members * Revert "Implement `onCondition` inline function of `dEvt_info_c`" This reverts commit dc7e945. * use `i_onCondition` instead of `onCondition` * make l_ statics local * remove uncessesary parenthesis * make actor function pointers return ints * make l_check_area a Vec[4]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first attempt at decompilation so please tell me if anything can be improved.
d_a_obj_bmshutteruses theonConditioninline function ofdEvt_info_cso the first commit implements that.