Merged
Conversation
hatal175
reviewed
Mar 23, 2025
| return; | ||
| } | ||
| if (mDestroyed != false) { | ||
| for (int index = 2; index <= 3; index++){ |
Contributor
There was a problem hiding this comment.
Is the <= 3 necessary? for loops are usually written with <. Same in the next loop.
Contributor
Author
There was a problem hiding this comment.
With <4 I get
cmpwi r24, 0x4
blt -0x64
when the target is
cmpwi r24, 0x3
ble -0x64
I'm not sure it will work with <4 or <2 even though it's ugly
TakaRikka
reviewed
Mar 23, 2025
TakaRikka
approved these changes
Mar 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1030