d_a_b_mgn (Dark Beast Ganon)#2348
Conversation
src/d/actor/d_a_b_mgn.cpp
Outdated
| static int daB_MGN_Draw(daB_MGN_c* i_this) { | ||
| i_this->draw(); |
There was a problem hiding this comment.
remember to actually return the function return value in these methods
src/d/actor/d_a_b_mgn.cpp
Outdated
| if (fopAcM_searchActorDistance((fopAc_ac_c*)param_1, (fopAc_ac_c*)param_2) < 1500.0f) { | ||
| f32 fVar1 = fopAcM_GetSpeedF((fopAc_ac_c*)param_1); | ||
| if (fVar1 != 0.0f) { | ||
| s16 sVar1 = *(s16*)((int)param_1 + 0x4de); |
There was a problem hiding this comment.
you can just cast param_1 to fopAc_ac_c here and get what looks like current.angle.y
There was a problem hiding this comment.
I tried implementing this but it didn't seem to work. Maybe I just don't quite understand what you mean?
There was a problem hiding this comment.
something like
s16 svar1 = ((fopAc_ac_c*)param_1)->current.angle.y;
src/d/actor/d_a_b_mgn.cpp
Outdated
| */ | ||
| int iVar2 = -1; | ||
| int unaff_r29; | ||
| if (mpModelMorf->mFrameCtrl.checkPass(40.0f)) { |
There was a problem hiding this comment.
these checkPass calls should be mpModelMorf->checkFrame, make sure you're looking at the debug rom's version to get all the correct inlines
src/d/actor/d_a_b_mgn.cpp
Outdated
| dBgS_GndChk dStack_6c; | ||
| cXyz local_78; | ||
|
|
||
| PSMTXCopy(mpModelMorf->getModel()->getAnmMtx(0x34), mDoMtx_stack_c::now); |
src/d/actor/d_a_b_mgn.cpp
Outdated
| fopAcM_effSmokeSet1(&field_0x25f8[0], &field_0x2608[0], &local_78, NULL, 15.0f, &tevStr, 1); | ||
| } | ||
|
|
||
| PSMTXCopy(mpModelMorf->getModel()->getAnmMtx(0x25), mDoMtx_stack_c::now); |
src/d/actor/d_a_b_mgn.cpp
Outdated
| static void daB_MGN_Delete(daB_MGN_c* i_this) { | ||
| i_this->_delete(); | ||
| } |
src/d/actor/d_a_b_mgn.cpp
Outdated
| int daB_MGN_c::CreateHeap() { | ||
| // NONMATCHING | ||
| J3DModelData* modelData = (J3DModelData*)dComIfG_getObjectRes("B_mgn", 0x2f); | ||
| JUT_ASSERT(modelData != 0); |
There was a problem hiding this comment.
make sure to include the line numbers for JUT_ASSERTS so it doesnt break the debug rom building
src/d/actor/d_a_b_mgn.cpp
Outdated
| static int useHeapInit(fopAc_ac_c* a_this) { | ||
| daB_MGN_c* i_this = (daB_MGN_c*)a_this; | ||
| i_this->CreateHeap(); |
src/d/actor/d_a_b_mgn.cpp
Outdated
|
|
||
| attention_info.flags = 0; | ||
| attention_info.distances[2] = 0x16; | ||
| attention_info.distances[4] = '('; |
There was a problem hiding this comment.
should be numerical value, not character
| static int daB_MGN_Create(daB_MGN_c* i_this) { | ||
| i_this->create(); | ||
| } |
2 participants
Significant work on d_a_b_mgn