Merged
Conversation
TakaRikka
reviewed
Mar 27, 2025
src/d/actor/d_a_obj_timer.cpp
Outdated
Comment on lines
+18
to
+28
| if (fopAcM_isSwitch(this, prm_get_sw2Save())) { | ||
| rv = 5; | ||
| } else { | ||
| if (fopAcM_isSwitch(this, prm_get_swSave())) { | ||
| mode_count_init(); | ||
| } else { | ||
| mode_wait_init(); | ||
| } | ||
| rv = 4; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
the 5 and 4 here can be replaced with cPhs_ERROR_e and cPhs_COMPLEATE_e
src/d/actor/d_a_obj_timer.cpp
Outdated
|
|
||
| if (!field_0x570) { | ||
| field_0x56c--; | ||
| if (prm_get_SeStop() && ((field_0x56c / 30) * field_0x56c - field_0x56c) == 0) { |
Contributor
There was a problem hiding this comment.
fairly sure that pattern there with field_0x56c is a modulo operation?
src/d/actor/d_a_obj_timer.cpp
Outdated
| * Mthd_Create__Q210daObjTimer27@unnamed@d_a_obj_timer_cpp@FPv */ | ||
| static void func_804855A4() { | ||
| // NONMATCHING | ||
| /* 804855A4-804855C0 .text daObjTimer::@unnamed@d_a_obj_timer_cpp@::Mthd_Create */ |
Contributor
There was a problem hiding this comment.
all of these functions / data that have @unnamed@d_a_obj_timer_cpp@ in them should be wrapped in an anonymous namespace to get the name mangling correct
TakaRikka
approved these changes
Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.