d_event_debug equivalent & modifications to dEvLib_callback_c#2359
Merged
TakaRikka merged 5 commits intozeldaret:mainfrom Mar 31, 2025
Merged
d_event_debug equivalent & modifications to dEvLib_callback_c#2359TakaRikka merged 5 commits intozeldaret:mainfrom
TakaRikka merged 5 commits intozeldaret:mainfrom
Conversation
* Implemented most functions close to matching * Removed erroneous comment in d_com_inf_game.h * Implemented getEventP in dEvDtBase_c * Retyped dEvLib_callback_c function returns from BOOL to bool * Implemented getHeader, getEventList, and setDbgData in dEvent_manager_c * Moved relevant dEvDb_* classes from d_event.h to d_event_debug.h and changed to structs * Extended JORFile mFilename character array from 8 to 256 characters * Implemented combo boxes and update slider functionalities in JORMContext * Named field_0xC of JORProperyEvent as id, based on use of field in d_event_debug.cpp * Corrected debug event tables and created missing table * Debug tables explicitly pasted in d_event_debug.cpp to circumvent ShiftJIS not properly encoding tables via #include directive
…inherit from dEvLib_callback_c
…ent_debug, and change respective fields in dEvDb_bit & reg_c to be const
* Changed configure.py entry to equivalent instead of matching * Preliminary documentation
TakaRikka
reviewed
Mar 30, 2025
Contributor
TakaRikka
left a comment
TakaRikka
left a comment
There was a problem hiding this comment.
overall looks fine, just ensure that there's no regressions in unlinked TUs and i'll merge it
Comment on lines
+1829
to
+1841
| inline void dComIfGs_setTmpReg(const u16 i_reg, u8 i_no) { | ||
| g_dComIfG_gameInfo.info.getTmp().setEventReg(i_reg, i_no); | ||
| } | ||
|
|
||
| inline u8 dComIfGs_getTmpReg(u16 i_reg) { | ||
| inline u8 dComIfGs_getTmpReg(const u16 i_reg) { | ||
| return g_dComIfG_gameInfo.info.getTmp().getEventReg(i_reg); | ||
| } | ||
|
|
||
| inline u8 dComIfGs_getEventReg(u16 reg) { | ||
| inline u8 dComIfGs_getEventReg(const u16 reg) { | ||
| return g_dComIfG_gameInfo.info.getEvent().getEventReg(reg); | ||
| } | ||
|
|
||
| inline void dComIfGs_setEventReg(u16 reg, u8 value) { | ||
| inline void dComIfGs_setEventReg(const u16 reg, u8 value) { |
Contributor
There was a problem hiding this comment.
for all these const changes, did you confirm that it doesn't cause regressions in unlinked TUs?
Contributor
Author
There was a problem hiding this comment.
Regression testing was done using the following command:
git checkout main && ninja && objdiff-cli report generate > report-before.json && git checkout EVT_DEBUG && ninja && objdiff-cli report generate > report-after.json && objdiff-cli report changes report-before.json report-after.json --format json-pretty > report-diff.json
Attached are the generated JSON files for GZ2E01.
report-after-GZ2E01.json
report-before-GZ2E01.json
report-diff-GZ2E01.json
However, when I attempt to do the same for ShieldD, running objdiff-cli report generate yields the following error:
INFO Loading project .
INFO Generating report for 3201 units (using 16 threads)
Failed: Failed to open ./build/ShieldD/src/REL/executor.o
Caused by:
No such file or directory (os error 2)
Contributor
There was a problem hiding this comment.
interesting, that actually seemed to fix a d_save function lol, good job. dw about shield, this is fine
TakaRikka
approved these changes
Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.