Merged
Conversation
TakaRikka
reviewed
Apr 2, 2025
include/d/actor/d_a_npc_midp.h
Outdated
Comment on lines
+94
to
+131
| /* 0x00 */ f32 field_0x00; // 210.0f | ||
| /* 0x04 */ f32 mGravity; // -3.0f | ||
| /* 0x08 */ f32 field_0x08; // 1.0f | ||
| /* 0x0C */ f32 field_0x0c; // 500.0f | ||
| /* 0x10 */ f32 mWeight; // 255.0f | ||
| /* 0x14 */ f32 mCylH; // 190.0f | ||
| /* 0x18 */ f32 mWallH; // 35.0f | ||
| /* 0x1C */ f32 mWallR; // 30.0f | ||
| /* 0x20 */ f32 field_0x20; // 0.0f | ||
| /* 0x24 */ f32 field_0x24; // 0.0f | ||
| /* 0x28 */ f32 field_0x28; // 10.0f | ||
| /* 0x2C */ f32 field_0x2c; // -10.0f | ||
| /* 0x30 */ f32 field_0x30; // 30.0f | ||
| /* 0x34 */ f32 field_0x34; // 10.0f | ||
| /* 0x38 */ f32 field_0x38; // 45.0f | ||
| /* 0x3C */ f32 field_0x3c; // -45.0f | ||
| /* 0x40 */ f32 field_0x40; // 0.6f | ||
| /* 0x44 */ f32 mMorfFrames; // 12.0f | ||
| /* 0x48 */ s16 field_0x48; // 3 | ||
| /* 0x4A */ s16 field_0x4a; // 6 | ||
| /* 0x4C */ s16 field_0x4c; // 5 | ||
| /* 0x4E */ s16 field_0x4e; // 6 | ||
| /* 0x50 */ f32 field_0x50; // 110.0f | ||
| /* 0x54 */ f32 field_0x54; // 0.0f | ||
| /* 0x58 */ f32 field_0x58; // 0.0f | ||
| /* 0x5C */ f32 field_0x5c; // 0.0f | ||
| /* 0x60 */ s16 field_0x60; // 60 | ||
| /* 0x62 */ s16 field_0x62; // 8 | ||
| /* 0x64 */ int field_0x64; // 0 | ||
| /* 0x68 */ int field_0x68; // 0 | ||
| /* 0x6C */ f32 field_0x6c; // 4.0f | ||
| /* 0x70 */ f32 field_0x70; // 0.0f | ||
| /* 0x74 */ f32 field_0x74; // 0.0f | ||
| /* 0x78 */ f32 field_0x78; // 0.0f | ||
| /* 0x7C */ f32 field_0x7c; // 0.0f | ||
| /* 0x80 */ f32 field_0x80; // 0.0f | ||
| /* 0x84 */ f32 field_0x84; // 0.0f | ||
| /* 0x88 */ f32 field_0x88; // 0.0f |
Contributor
There was a problem hiding this comment.
imo adding the constant here isn't really necessary. i'd rather put a comment of the member name in the actual data initializer than this
src/d/actor/d_a_npc_midp.cpp
Outdated
| void daNpc_midP_c::Delete() { | ||
| // NONMATCHING | ||
| int daNpc_midP_c::Delete() { | ||
| OS_REPORT("|%06d:%x|daNpc_midP_c -> Delete\n", g_Counter, this); |
src/d/actor/d_a_npc_midp.cpp
Outdated
|
|
||
| /* 80A727D4-80A727DC 001C54 0008+00 1/0 0/0 0/0 .text daNpc_midP_IsDelete__FPv */ | ||
| static bool daNpc_midP_IsDelete(void* param_0) { | ||
| static bool daNpc_midP_IsDelete(void* i_this) { |
Contributor
Author
There was a problem hiding this comment.
One day I’ll get the int returns down😂
TakaRikka
approved these changes
Apr 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.