Debug JStudio fix + match one retail func#2378
Merged
TakaRikka merged 6 commits intozeldaret:mainfrom Apr 7, 2025
Merged
Conversation
Contributor
|
the fake header stuff is unfortunate cause its pretty ugly, but if its the only way to support both versions then i guess we'll have to live with it |
Contributor
Author
Maybe someone who knows more about C++ templates could find a better way, I still don't really understand why the newer compiler version refuses to let the template class be used after it's defined which seems pretty backwards. But yeah I couldn't think of an alternative |
TakaRikka
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weird gameinfo load in daAlink_c::getDemoLookActor was caused by the redundant cast, some callers need the extra cast and some don't