Skip to content

d_a_e_ms Equivalent#2405

Merged
hatal175 merged 2 commits intozeldaret:mainfrom
ItsNiklas:d_a_e_ms
Apr 21, 2025
Merged

d_a_e_ms Equivalent#2405
hatal175 merged 2 commits intozeldaret:mainfrom
ItsNiklas:d_a_e_ms

Conversation

@ItsNiklas
Copy link
Copy Markdown
Contributor

@ItsNiklas ItsNiklas commented Apr 21, 2025

Builds on top of #2394, to fix all outstanding issues. Except for weak function order (I think) regarding setMidnaBindEffect, which gets placed too early.

Some cleaning (clang format?!), but mostly fixing regallocs etc. Also a nasty goto fakematch in search_dokuro...

@decomp-dev
Copy link
Copy Markdown

decomp-dev bot commented Apr 21, 2025

Report for GZ2E01 (2e10e62 - 198ebf4)

📈 Matched code: 57.13% (+0.04%, +5132 bytes)

d_a_e_ms/d/actor/d_a_e_ms | search_dokuro(e_ms_class*) +185 bytes -> 100.00%
d_a_e_ms/d/actor/d_a_e_ms | way_set(e_ms_class*) +164 bytes -> 100.00%
d_a_e_ms/d/actor/d_a_e_ms | e_ms_damage(e_ms_class*) +12 bytes -> 100.00%
d_a_e_ms/d/actor/d_a_e_ms | action(e_ms_class*) +541 bytes -> 100.00%
d_a_e_ms/d/actor/d_a_e_ms | daE_MS_Execute(e_ms_class*) +158 bytes -> 100.00%
d_a_e_ms/d/actor/d_a_e_ms | setMidnaBindEffect(fopEn_enemy_c*, Z2CreatureEnemy*, cXyz*, cXyz*) +21 bytes -> 100.00%

@hatal175
Copy link
Copy Markdown
Contributor

This matches without the goto https://decomp.me/scratch/LkReJ

@hatal175 hatal175 merged commit bbabe0c into zeldaret:main Apr 21, 2025
1 check passed
@ItsNiklas ItsNiklas deleted the d_a_e_ms branch May 9, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants